[WIP] Allowing Testing on External Forks #1559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need to add protections provided by an environment that ensures approval from |
|
Btw @coolkingcole, since the test workflow stores containers in GHCR, but it seems this is linked to a user account, not sure how pull_request_target would work for that. At least secure use of pull_request_target means that you can securely share secrets. You might need to switch to storing test containers in DockerHub too. Just something to note when testing this. |
AndrewQuijano
changed the title
AndrewQuijano
force-pushed
the
external-pr
branch
from
dc58167 to
cbf67f1
Compare
AndrewQuijano
force-pushed
the
external-pr
branch
from
cbf67f1 to
a548ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, (Update Feb 2, 2025)
So I have been testing running tests on external forks, and I think I got it working safely with this example
adwise-fiu/Level-Site-PPDT#14
So for set up, I did the following
1- Setup branch protection rule
2- Update Action to allow external forks
3- See the updated workflow, so essentially what happens is,
a) Someone creates a Pull Request
b) Before the option appears to even run the test cases, I need the changes approved, once I see that checkmark, then the option to run test cases appears, and I click OK and run the tests.
The security comes from needing a manual approval. The GitHub Actions will prevent ANY code being run until Step A is completed.
There is one slight issue, the reviewer can't be the same person writing the PR, which is technically more secure, but does slightly make things a bit more annoying?