Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Personal Access Token Rejected #374

Open
aweingarten opened this issue Apr 9, 2021 · 2 comments
Open

GitHub Personal Access Token Rejected #374

aweingarten opened this issue Apr 9, 2021 · 2 comments

Comments

@aweingarten
Copy link
Contributor

When trying to use terminus build:project:create --git=github build tools no longer accepts github access tokens. It returns the following errror: GitHub authentication tokens should be 40-character strings containing only the letters a-f and digits (0-9). Please enter your token again.

It looks like GitHub changed their token format:
https://github.blog/2021-04-05-behind-githubs-new-authentication-token-formats/

We will need to update the token validation code to handle the new format.

@aweingarten
Copy link
Contributor Author

Looks like the issue is that the regex here needs a simple-update:

->setValidateRegEx('#^[0-9a-fA-F]{40}$#')

@sugaroverflow
Copy link
Contributor

sugaroverflow commented Apr 9, 2021

This got merged into main 🎉 - I can cut a release later today (waiting in case we get that D9 support PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants