Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to /* That’s all, stop editing! Happy publishing. */ line #158

Open
jazzsequence opened this issue Aug 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jazzsequence
Copy link
Contributor

jazzsequence commented Aug 13, 2024

The multisite setup instructions say to add the multisite config above the /* That’s all, stop editing! Happy publishing. */ line in the config/application.php file.

However, this file does not have that line. This should be updated to use a different marker (like above the Config::apply() line or above the $env_config ... line.

This would need to be added to the filter that already exists to change the network setup page.

Blocked by pantheon-systems/pantheon-mu-plugin#55

@jazzsequence
Copy link
Contributor Author

The existing filter only applies to the configuration code, not the full text of this screen. No filter currently exists for the rest of the content on the page. Created pantheon-systems/pantheon-mu-plugin#55 to fix this in the mu-plugin first.

@jazzsequence jazzsequence added the blocked Issues that cannot be started until a linked issue is resolved label Aug 13, 2024
@jazzsequence jazzsequence added enhancement New feature or request and removed blocked Issues that cannot be started until a linked issue is resolved labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant