-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting pants shows useless "Initializing Nailgun pool ..." log lines #21863
Comments
The relevant diff of releases is: release_2.22.0.dev3...release_2.22.0a0 Looks like #20946 introduced this line, after turning some other logs down. |
I've also wondered, why does the same log message appear twice? Do we initialize twice? |
I'm not sure yet. Initial investigation: Extra factor, with pantsd (i.e. no cd $(mktemp -d)
touch pants.toml
echo "First"
PANTS_VERSION=2.22.0 pants version
echo
echo "Second"
PANTS_VERSION=2.22.0 pants version
There's a few layers of functions from
Finally,
Thus, for why things happen twice, the surface level is that the scheduler is initialised/graph is set-up for both bootstrapping (call site 1 is eventually also called in or before For why Pantsd behaves differently... my current hypothesises are:
|
This just updates the Pants version used for linting etc., should be no functional change. This requires a few extra changes: - CI here runs on older versions of macOS that we're removing support for (#421) and thus needs to silence the warnings with `allow_deprecated_macos_before_12` - doing so causes issues with a few tests that ran against this repo's `pants.toml` with older versions of Pants that don't understand that option, and thus those tests are adjusted to use a dedicated `pants.toml` - working around pantsbuild/pants#21863
Describe the bug
It seems that Pants recently (between 2.21 and 2.22) started always logging two log lines about initializing Nailgun. These seem of low interest in most circumstances, and thus not worth telling the user about.
Reproducer:
Output:
Pants version
2.22.0a0 and newer
OS
macOS
Additional info
N/A
The text was updated successfully, but these errors were encountered: