Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove variable shadowing #60

Open
panwauu opened this issue Aug 1, 2022 · 0 comments
Open

Refactor: remove variable shadowing #60

panwauu opened this issue Aug 1, 2022 · 0 comments
Labels
good first issue Good for newcomers Type: Refactor Aesthetic changes

Comments

@panwauu
Copy link
Owner

panwauu commented Aug 1, 2022

Describe the bug

Overriding or shadowing a variable declared in an outer scope can strongly impact the readability, and therefore the maintainability, of a piece of code. Further, it could lead maintainers to introduce bugs because they think they’re using one variable but are really using another.

  • Add 'no-shadow': ['error'] to .eslintrc.js in server
  • Add 'no-shadow': ['error'] to .eslintrc.js in client
  • Rename until npm run lint shows no more errors
@panwauu panwauu added Type: Bug Something isn't working good first issue Good for newcomers Type: Refactor Aesthetic changes and removed Type: Bug Something isn't working labels Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Type: Refactor Aesthetic changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@panwauu