You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After some usages of the batch request API and if one constructs a too big request or response it's not easy to understand.
For instance the jsonrpsee server will reply with ["batch too large", "id": null] which we doesn't handle differently in the clients.
For the async-client/websocket client one would get some error message such Invalid RequestId which isn't user-friendly and a better log/error should be propagated to the user.
For the http client is possible to detect by matching on the error but one really have to downcast the error which isn't good either.
Thus,
Provide concrete error types/variants instead of using anyhow::Error
Add a some concrete error variant InvalidBatchResponse
Optionally, add some documentation that batch requests might bump into the max_request, max_response limits.
The text was updated successfully, but these errors were encountered:
After some usages of the batch request API and if one constructs a too big request or response it's not easy to understand.
For instance the
jsonrpsee server
will reply with["batch too large", "id": null]
which we doesn't handle differently in the clients.For the async-client/websocket client one would get some error message such
Invalid RequestId
which isn't user-friendly and a better log/error should be propagated to the user.For the http client is possible to detect by matching on the error but one really have to downcast the error which isn't good either.
Thus,
InvalidBatchResponse
Optionally, add some documentation that batch requests might bump into the
max_request
,max_response
limits.The text was updated successfully, but these errors were encountered: