Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make target optional in Processed data. #32

Closed
mlahariya opened this issue Jan 23, 2025 · 2 comments
Closed

[Feature] Make target optional in Processed data. #32

mlahariya opened this issue Jan 23, 2025 · 2 comments
Assignees

Comments

@mlahariya
Copy link
Collaborator

We should have target as optional input in ProcessedData. Right now target = int. For testing trained models, target is not always available and it should be None.

Eg. we have a trained model M, and we want to evaluate it for a new graphs. We will have to do something like

pd = prepare_processed_data(graph)
target_predicted = M(pd)

Now here - pd itself will have the real target value - which seems very counter intuitive when we are predicting something. Some can claim that the model M does only the follwoing

Def M(pd):
      return pd.target
@mlahariya mlahariya self-assigned this Jan 23, 2025
@Yoric
Copy link
Collaborator

Yoric commented Jan 29, 2025

I have a PR nearly ready for this.

@Yoric
Copy link
Collaborator

Yoric commented Feb 4, 2025

Solved by #36 .

@Yoric Yoric closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants