Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research Deduplication for Humanode #1383

Closed
erichfi opened this issue Jun 20, 2023 · 4 comments
Closed

Research Deduplication for Humanode #1383

erichfi opened this issue Jun 20, 2023 · 4 comments
Assignees

Comments

@erichfi
Copy link
Contributor

erichfi commented Jun 20, 2023

No description provided.

@erichfi erichfi added this to Passport Jun 20, 2023
@erichfi erichfi converted this from a draft issue Jun 20, 2023
@nutrina nutrina moved this from Backlog to In Progress (WIP) in Passport Jun 23, 2023
@Jkd-eth
Copy link
Contributor

Jkd-eth commented Jul 10, 2023

This is dependent on #1249 as we need some additional fields in the VC to store the Epoch

@Jkd-eth Jkd-eth moved this from In Progress (WIP) to Blocked in Passport Jul 10, 2023
@erichfi erichfi moved this from Blocked to Backlog in Passport Jul 24, 2023
@nutrina nutrina moved this from Backlog to In Progress (WIP) in Passport Jul 25, 2023
@nutrina
Copy link
Collaborator

nutrina commented Jul 25, 2023

One of the open points was about how to set custom (short) expiration time.

This is possible as shown here in this example: https://github.com/gitcoinco/passport/blob/739bd2c78ac74d8c0e9f8413bc2b3a4df942d06c/platforms/src/Civic/Providers/civic.ts#L47C16-L47C16

In addition we now allow a customInfo field in the new schema, which would allow a stamp provider to store custom information about stamp issuance (epoch, season, server id, etc ...). In case of a breach we could potentially revoke stamps based on this information.

@nutrina nutrina moved this from In Progress (WIP) to Product/UX Review in Passport Jul 25, 2023
@nutrina
Copy link
Collaborator

nutrina commented Jul 25, 2023

@erichfi this can be closed, no further action needed.
But we might want to keep my comment above and include it in the new docs (for the new schema).

@erichfi
Copy link
Contributor Author

erichfi commented Jul 27, 2023

okay, unblocking this as a consequence: #1277

@erichfi erichfi closed this as completed Jul 27, 2023
@erichfi erichfi moved this from Product/UX Review to Ready to Deploy in Passport Jul 27, 2023
@erichfi erichfi removed this from Passport Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants