Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page - Penta changes #548

Closed
tlabaj opened this issue Jan 9, 2024 · 0 comments · Fixed by #579
Closed

Page - Penta changes #548

tlabaj opened this issue Jan 9, 2024 · 0 comments · Fixed by #579
Assignees
@Dominik-Petrik
Labels
codemod
Milestone
Penta alpha release

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Jan 9, 2024 •
edited by Dominik-Petrik
Loading

Follow up to breaking change PR patternfly/patternfly-react#9948

  1. Update prop name from isTertiaryNavWidthLimited to isHorizontalSubnavWidthLimited
  2. Update prop name from tertiaryNav to horizontalSubnav
  3. Update prop name from isTertiaryNavGrouped to isHorizontalSubnavGrouped

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@tlabaj tlabaj added the codemod label Jan 9, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 9, 2024
@tlabaj tlabaj added this to the Penta alpha release milestone Feb 14, 2024
@Dominik-Petrik Dominik-Petrik self-assigned this Feb 20, 2024
@Dominik-Petrik Dominik-Petrik mentioned this issue Feb 20, 2024
Merged
@Dominik-Petrik Dominik-Petrik moved this from Needs triage to In Progress in PatternFly Issues Feb 20, 2024
@Dominik-Petrik Dominik-Petrik moved this from In Progress to PR Review in PatternFly Issues Feb 20, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dominik-Petrik Dominik-Petrik

Labels
codemod
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha release
Development

Successfully merging a pull request may close this issue.

Page penta updates Dominik-Petrik/pf-codemods
3 participants
@tlabaj @Dominik-Petrik @adamviktora