Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated components - warn about removal of deprecated components #664

Closed
wise-king-sullyman opened this issue Jun 14, 2024 · 0 comments · Fixed by #684
Closed
Assignees
Labels

Comments

@wise-king-sullyman
Copy link
Collaborator

Follow up to breaking change PR patternfly/patternfly-react#10345

We should give consumers an explicit heads up about deprecated components which have now been removed.

Ideally they should have customized error messages, I.e. for the select or dropdown we might want to suggest consumers look at the templates, for context selector we can point them towards the context selector example in our custom menus, etc

Though these would more or less be warnings the rule should throw errors and not warnings, since removed components that are in consumer codebases will cause build errors.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jun 14, 2024
@thatblindgeye thatblindgeye added this to the Penta beta release milestone Jul 3, 2024
@thatblindgeye thatblindgeye self-assigned this Jul 3, 2024
@nicolethoen nicolethoen moved this from Needs triage to Not started in PatternFly Issues Jul 3, 2024
@thatblindgeye thatblindgeye moved this from Not started to In Progress in PatternFly Issues Jul 8, 2024
@thatblindgeye thatblindgeye moved this from In Progress to PR Review in PatternFly Issues Jul 8, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants