Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component-groups | InvalidObject] - Rename props #666

Closed
fhlavac opened this issue Jun 20, 2024 · 0 comments · Fixed by #714
Closed

[component-groups | InvalidObject] - Rename props #666

fhlavac opened this issue Jun 20, 2024 · 0 comments · Fixed by #714
Assignees

Comments

@fhlavac
Copy link

fhlavac commented Jun 20, 2024

Follow up to breaking change PR

We've renamed some ErrorState props to comply with its base component - PF EmptyState

rename
invalidObjectTitleText to titleText
invalidObjectBodyText to bodyText

Example:

<InvalidObject invalidObjectTitleText='Sample title' invalidObjectBodyText='Sample description' />

becomes

<InvalidObject titleText='Sample title' bodyText='Sample description' />

Required actions:

  • Build codemod
  • Build test
  • Update readme with description & example
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jun 20, 2024
@adamviktora adamviktora self-assigned this Jul 23, 2024
@adamviktora adamviktora moved this from Needs triage to Not started in PatternFly Issues Jul 24, 2024
@adamviktora adamviktora moved this from Not started to PR Review in PatternFly Issues Jul 25, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants