Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch - Removed labelOff prop #672

Closed
thatblindgeye opened this issue Jun 24, 2024 · 0 comments · Fixed by #686
Closed

Switch - Removed labelOff prop #672

thatblindgeye opened this issue Jun 24, 2024 · 0 comments · Fixed by #686
Assignees
@thatblindgeye
Labels
codemod
Milestone
Penta beta release

Comments

@thatblindgeye
Copy link
Collaborator

Follow up to breaking change PR patternfly/patternfly-react#10646

We're removing the labelOff prop to aid in preventing dynamic Switch labels that can worsen a11y. In addition we're adding the role="switch" to the input.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@thatblindgeye thatblindgeye self-assigned this Jun 24, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jun 24, 2024
@thatblindgeye thatblindgeye mentioned this issue Jun 24, 2024
Merged
@nicolethoen nicolethoen added this to the Penta beta release milestone Jul 3, 2024
@nicolethoen nicolethoen moved this from Needs triage to Not started in PatternFly Issues Jul 3, 2024
@thatblindgeye thatblindgeye mentioned this issue Jul 8, 2024
Merged
@thatblindgeye thatblindgeye moved this from Not started to PR Review in PatternFly Issues Jul 8, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
codemod
Projects
PatternFly Issues
Archived in project
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

fix(Switch): removed labelOff prop for a11y thatblindgeye/pf-codemods
2 participants
@nicolethoen @thatblindgeye