Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text to Content codemod - apply the fix in one run (handle nested JSXElements) #708

Closed
adamviktora opened this issue Jul 22, 2024 · 0 comments · Fixed by #726
Closed

Text to Content codemod - apply the fix in one run (handle nested JSXElements) #708

adamviktora opened this issue Jul 22, 2024 · 0 comments · Fixed by #726
Assignees
@adamviktora
Labels
codemod

Comments

@adamviktora
Copy link
Contributor

adamviktora commented Jul 22, 2024 •
edited
Loading

Fix the text-replace-with-content rule in a way so the fix is applied in 1 run so the currently commented tests pass and it works correctly for > 10 nested elements
@adamviktora adamviktora self-assigned this Jul 22, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jul 22, 2024
@adamviktora adamviktora changed the title Text to Content codemod - fix duplicate Content imports Text to Content codemod - apply the fix in one run (handle nested JSX Elements Jul 24, 2024
@adamviktora adamviktora changed the title Text to Content codemod - apply the fix in one run (handle nested JSX Elements Text to Content codemod - apply the fix in one run (handle nested JSXElements) Jul 24, 2024
@adamviktora adamviktora moved this from Needs triage to In Progress in PatternFly Issues Jul 24, 2024
@adamviktora adamviktora mentioned this issue Jul 31, 2024
Merged
@adamviktora adamviktora linked a pull request Jul 31, 2024 that will close this issue
fix(textReplaceWithContent): fix nested JSXElements handling #726
Merged
@adamviktora adamviktora moved this from In Progress to PR Review in PatternFly Issues Jul 31, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamviktora adamviktora

Labels
codemod
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(textReplaceWithContent): fix nested JSXElements handling adamviktora/pf-codemods
1 participant
@adamviktora