Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The push function of the sendQueue in DataChannel will trigger wait and can not be awaked. #1219

Closed
the-loki opened this issue Jul 2, 2024 · 3 comments · Fixed by #1221
Closed

The push function of the sendQueue in DataChannel will trigger wait and can not be awaked. #1219

the-loki opened this issue Jul 2, 2024 · 3 comments · Fixed by #1221

Comments

@the-loki
Copy link

the-loki commented Jul 2, 2024

The push function of the sendQueue in DataChannel will trigger waiting when the number of elements in the queue reaches its limit under capacity constraints. However, there is no place other than close that wakes up the thread.

YoloMouse_Zg07sbFcEr
@paullouisageneau paullouisageneau mentioned this issue Jul 2, 2024
Merged
@paullouisageneau paullouisageneau linked a pull request Jul 2, 2024 that will close this issue
Fix missing notify on queue limit preventing thread from waking up #1221
Merged
@paullouisageneau
Copy link
Owner

Good catch, this is fixed by #1221

@paullouisageneau
Copy link
Owner

Released in v0.21.2

@the-loki
Copy link
Author

the-loki commented Jul 2, 2024

Good catch, this is fixed by #1221

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing notify on queue limit preventing thread from waking up paullouisageneau/libdatachannel
2 participants
@paullouisageneau @the-loki