Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure events, duration during a run #53

Open
ZLLentz opened this issue Nov 27, 2018 · 3 comments
Open

Add ability to configure events, duration during a run #53

ZLLentz opened this issue Nov 27, 2018 · 3 comments

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Nov 27, 2018

Expected Behavior

Daq.configure needs to be callable in the middle of a bluesky plan if we want to change the length of a trigger_and_read call, e.g. run for x events and then change something and run for y events.

Current Behavior

Cannot call configure at all if a run is open.

Possible Solution

Only the first configure and changes to record state should actually trigger a pydaq.Control.configure call. Every other configurable should be saved and passed through to pydaq.Control.begin.

Context

There are use cases for taking n dark shots and m light shots, where n!=m, and this pattern looks something like:

yield from configure(daq, record=True)
yield from open_run()
yield from configure(daq, events=n)
yield from trigger_and_read(daq)
yield from configure(daq, events=m)
yield from trigger_and_read(daq)
yield from close_run()
@slactjohnson
Copy link

@ZLLentz I would like to take a swing at this (MEC needs this functionality), but I think I need to discuss with you first. Do you have some time to talk about this in the next week or so?

@ZLLentz
Copy link
Member Author

ZLLentz commented Jun 7, 2019

Hey @slactjohnson, happy to talk about this any time. We could review the code together, I don't quite remember what it looks like.

@slactjohnson
Copy link

@ZLLentz Sounds good. Let's plan on next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants