Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for connection params #5

Open
ftrudeau-pelcro opened this issue Jul 15, 2024 · 4 comments
Open

Support for connection params #5

ftrudeau-pelcro opened this issue Jul 15, 2024 · 4 comments

Comments

@ftrudeau-pelcro
Copy link

ftrudeau-pelcro commented Jul 15, 2024

Hey @pdphilip, not an issue, just a small contrib.

I forked your repo and added this small change.

Not sure your repo is ready to accept PRs, so feel free to include this in an upcoming release on your side.

@pdphilip
Copy link
Owner

This is great @ftrudeau-pelcro

I'll bring in your PR and also include the option to have multiple connections as I did for the Elasticsearch version in the next release.

Thanks!

@pdphilip
Copy link
Owner

pdphilip commented Aug 1, 2024

Hey @ftrudeau-pelcro - Do you want to do a PR of this and join as a contributor?

I'm busy with the next release which will be ready soon and would like to include this upgrade. Thanks!

@ftrudeau-pelcro
Copy link
Author

@pdphilip - Sure, add me as a collaborator. Pretty busy at work, but I'll try to budget time to create the PR. Probably won't have time to introduce feature tests tho.

@pdphilip
Copy link
Owner

pdphilip commented Aug 2, 2024

No rush, I'll put out the new release today (without your changes), then when you're ready, fork the latest version (there's been changes to the connection file), make your edits and submit the PR.

Once I accept the PR, you'll automatically be added as a collaborator on the package home page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants