Using Invalid Method Should Return 405

[jamesyarrington]

When accessing some endpoints, it appears that only GET, OPTIONS and HEAD are appropriate HTTP Request Methods. If an invalid HTTP Request Method is used, the response is coded as 404 Not Found, but should be 405 Method Not Allowed.

To Reproduce:

1. Send a GET to /search/structured?locality=foo (200 OK returned)
2. Send a POST to that same URL.

Expected Response:
Server should respond with a 405 Method Not Allowed, with an appropriate message in the response body.
Actual Response:
404 Not Found

{
    "error": "not found: invalid path"
}

Additional Information:
Endpoints I've seen with this behavior:

• /
• /search (a POST actually returns a 200 OK here)
• /autocomplete
• /search/structured
• /place
• /reverse

[orangejulius]

Hey @jamesyarrington,
Thanks for the report. This is a good catch. Do you happen to know how to fix this with Express? We would definitely accept a pull request to do it :)

[missinglink]

This could be fairly easy to add in https://github.com/pelias/api/blob/master/routes/v1.js#L405-L418 using the method mentioned in expressjs/express#2414 (comment)

[orangejulius]

We can also revisit supporting POST for some of our endpoints (see #188). I don't believe its very necessary, but it could be helpful in some cases.

[moar55]

Hey there. I am working on this issue: moar55@2ed668e.
I want to know where to add tests for this issue. Also is this coding in the commit good? Can I make this more DRY?

[missinglink]

hey @moar55, the code looks good, I didn't have time to test it yet.

regarding testing, we used to have an HTTP test suite called ciao but it's not really been maintained, it's a framework that I created many years ago and we'd actually love to replace it with something more standard.

I tried running the tests using the npm run ciao method described in the README and it failed, probably because the code was developed on node ~0.6 (about 5 years old).

We would be very happy to accept a PR for a new HTTP test suite, if possible we'd also like to port over our existing tests https://github.com/pelias/api/tree/master/test/ciao