Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/v1/place: Add a warning when an id is not found #306

Open
trescube opened this issue Sep 24, 2015 · 3 comments
Open

/v1/place: Add a warning when an id is not found #306

trescube opened this issue Sep 24, 2015 · 3 comments
Labels
low hanging fruit processed
Milestone
API Improvements

Comments

@trescube
Copy link
Contributor

Just add a warning, the "substitute an empty JSON object" is no longer needed.
@trescube trescube changed the title Add empty JSON object to /place response when id is not found Add a warning when an id is not found Sep 28, 2015
@trescube
Copy link
Contributor Author

Only need a warning that ids couldn't be found, don't include an empty JSON object

@riordan riordan added processed and removed 1.next labels Jan 12, 2016
@riordan riordan added this to the Dependency Upgrades milestone Jan 21, 2016
@dianashk
Copy link
Contributor

dianashk commented Aug 4, 2017

We still don't provide a warning or error. Just return an empty geojson object.

http://pelias.github.io/compare/#/v1/Place%3Fids=openstreetmap:venue:node:1234

@missinglink
Copy link
Member

sorry, I don't understand what this ticket is about?

@orangejulius orangejulius changed the title Add a warning when an id is not found /v1/place: Add a warning when an id is not found Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low hanging fruit processed
Projects
None yet
Milestone
API Improvements
Development

No branches or pull requests
5 participants
@orangejulius @riordan @trescube @missinglink @dianashk