Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privacy flag should disable the 'geocoding.query' section #332

Open
missinglink opened this issue Oct 2, 2015 · 4 comments
Open

privacy flag should disable the 'geocoding.query' section #332

missinglink opened this issue Oct 2, 2015 · 4 comments
Labels

Comments

@missinglink
Copy link
Member

privacy flag should disable the 'geocoding.query' section as it may contain sensitive information such as the input query and the device position.

eg:

"query": {
  "text": "strip club",
  "private": true,
  "focus.point.lat": 40.744243,
  "focus.point.lon": -73.990342
}

we also need to ensure that privacy:true requests do not get cached in the edge cache, @heffergm I think this is set up already?

edit: the api should also return the Cache-Control: private header when privacy:true is set

@heffergm
Copy link
Contributor

heffergm commented Oct 2, 2015

If the origin receives a request that it deems private, it should return a response that includes a Cache-Control: private header. The edge will then pass the response directly back and not cache it.

@missinglink
Copy link
Member Author

ok cool thanks, I'm guessing that means that any requests coming from the privacy mobile app will bypass cache?

@heffergm
Copy link
Contributor

heffergm commented Oct 2, 2015

Assuming they're setting a flag that the backend responds to with a Cache-Control: private header, they should. We can have Chuck dump the output of some requests to confirm.

@riordan
Copy link
Contributor

riordan commented Jan 12, 2016

Do we have confirmation on this?

@riordan riordan added processed and removed 1.next labels Jan 12, 2016
@dianashk dianashk added ideas and removed processed labels Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants