From c99fb61a23769d5c97780309eb603c77d996f5a7 Mon Sep 17 00:00:00 2001
From: Julian Simioni <julian@simioni.org>
Date: Thu, 18 Jun 2020 09:02:46 -0700
Subject: [PATCH] draft: create fewer intersection variations

Just like with venues, adding many alt names can create scoring
penalties(https://github.com/pelias/pelias/issues/862) or
boosts(https://github.com/pelias/openstreetmap/issues/507) that are
undesirable.

Unfortunately we don't currently have a great way to handle all
intersection searches without _some_ alt-names, but this change tests
removing some of them to see if we can stabilize scoring a bit.
---
 post/intersections.js      | 14 +++++++-------
 test/post/intersections.js |  6 +-----
 2 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/post/intersections.js b/post/intersections.js
index 6faaff6..d0ca91f 100644
--- a/post/intersections.js
+++ b/post/intersections.js
@@ -12,7 +12,7 @@ function intersections( doc ){
   // ensure both street & cross street props are set
   let street = doc.getAddress(ADDRESS_STREET_PROP);
   if( !_.isString(street) || _.isEmpty(street) ){ return; }
-  
+
   let cross_street = doc.getAddress(ADDRESS_CROSS_STREET_PROP);
   if( !_.isString(cross_street) || _.isEmpty(cross_street) ){ return; }
 
@@ -21,15 +21,15 @@ function intersections( doc ){
 
   // corner of A & B
   doc.setNameAlias('default', `${street} & ${cross_street}`);
-  doc.setNameAlias('default', `${street} @ ${cross_street}`);
+  //doc.setNameAlias('default', `${street} @ ${cross_street}`);
   doc.setNameAlias('default', `${street} at ${cross_street}`);
-  doc.setNameAlias('default', `Corner of ${street} & ${cross_street}`);
-  
+  //doc.setNameAlias('default', `Corner of ${street} & ${cross_street}`);
+
   // corner of B & A
   doc.setNameAlias('default', `${cross_street} & ${street}`);
-  doc.setNameAlias('default', `${cross_street} @ ${street}`);
+  //doc.setNameAlias('default', `${cross_street} @ ${street}`);
   doc.setNameAlias('default', `${cross_street} at ${street}`);
-  doc.setNameAlias('default', `Corner of ${cross_street} & ${street}`);
+  //doc.setNameAlias('default', `Corner of ${cross_street} & ${street}`);
 }
 
-module.exports = intersections;
\ No newline at end of file
+module.exports = intersections;
diff --git a/test/post/intersections.js b/test/post/intersections.js
index 16acc5b..7616576 100644
--- a/test/post/intersections.js
+++ b/test/post/intersections.js
@@ -7,7 +7,7 @@ module.exports.tests = {};
 module.exports.tests.functional = function(test) {
   test('functional', function(t) {
     var doc = new Document('mysource','intersection','myid');
-    
+
     // street and cross_street not set
     intersections(doc);
     t.deepEqual(doc.getNameAliases('default'), [], 'no names set');
@@ -28,13 +28,9 @@ module.exports.tests.functional = function(test) {
     // intersection aliases defined
     t.deepEqual(doc.getNameAliases('default'), [
       'Example Street & Cross Street',
-      'Example Street @ Cross Street',
       'Example Street at Cross Street',
-      'Corner of Example Street & Cross Street',
       'Cross Street & Example Street',
-      'Cross Street @ Example Street',
       'Cross Street at Example Street',
-      'Corner of Cross Street & Example Street'
     ]);
 
     t.end();