Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roles to owner selector on Create/Edit Server page #935

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

RMartinOscar
Copy link
Contributor

@RMartinOscar RMartinOscar commented Jan 23, 2025

Before it shown
email | user
email | user (Admin)

now it shows
email | user
email | user (Root Admin)
email | user (Role1, Role2)

I would'v added a screenshot but the select shits the bed the moment i do it

@notAreYouScared
Copy link
Member

We should limit it to a single role... No point is listing them all when the box is only so big.

@RMartinOscar
Copy link
Contributor Author

RMartinOscar commented Jan 23, 2025

We should limit it to a single role... No point is listing them all when the box is only so big.

Seems fine to me it makes the record use an extra line the overflow is clean but if you really want to limit it i'll do ->first() instead
image

@RMartinOscar RMartinOscar merged commit 262e2fd into pelican-dev:main Jan 23, 2025
15 checks passed
@RMartinOscar RMartinOscar deleted the add/RoleToOwnerSelector branch January 23, 2025 01:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants