Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plate Locator Functionality #18

Open
amalnanavati opened this issue Apr 17, 2023 · 2 comments
Open

Plate Locator Functionality #18

amalnanavati opened this issue Apr 17, 2023 · 2 comments
Assignees
Labels
critical-path Issues that are critical path for deployment

Comments

@amalnanavati
Copy link
Contributor

amalnanavati commented Apr 17, 2023

(Currently blocked by #8 ).

Currently, only the Plate Locator UI is implemented, but it does not control the robot. We need to have each of the buttons send commands to the robot to move it. An important factor to consider before implementing this is how each button will be translated into the robot motion. A couple of examples include:

  1. For every time the user presses the button, the robot moves some distance (e.g., 1cm) in that direction. For this approach, the following questions need to be answered:
    1. What happens if the user clicks a button but then decides they don't want to move it in that direction?
    2. How far should it move in each click?
    3. Is this Tyler's preferred method of controlling the robot?
  2. While the user hold's down the button, the robot moves in that direction, and as soon as they let go,

We first need to come up with a proposal for how the button click gets transferred into robot motion, informed by user preferences and considerations for safety and such. After that, we need to implement the code, both on the robot side and on the UI side, to turn that into a reality.

@amalnanavati amalnanavati mentioned this issue Apr 17, 2023
2 tasks
@Raidakarim Raidakarim self-assigned this Apr 17, 2023
@Raidakarim
Copy link
Contributor

Raidakarim commented Apr 18, 2023

@amalnanavati I shared my thoughts yellow highlighted in this doc as a proposal responding to your above mentioned points of: how the button click gets transferred into robot motion, informed by user preferences and considerations for safety and such. Could you please take a look and share any feedback? If those look good to you, my proposed next steps are:

  • create onclicks for directional buttons in the plate locator app UI page
  • connect each onclick to a triggering function that moves the robot on that button click involving app<->ros communication and robot movement infrastructure

Let me know if you have any thoughts on these.

@amalnanavati amalnanavati added the critical-path Issues that are critical path for deployment label May 9, 2023
@Raidakarim
Copy link
Contributor

Raidakarim commented Jun 8, 2023

This issue should also implement Step-Action (Maybe wait 1 second for moving in clicked direction before stopping) for directional arrow button clicks and adjust lock icon appearance in the header so that it disappears when the robot is moving after an arrow click and re-appears before the next arrow button is clicked. See this slidedeck for more info. Looking into setTimeout in Javascript like in this StackOverflow post may help.

@Raidakarim Raidakarim mentioned this issue Jun 9, 2023
4 tasks
@Raidakarim Raidakarim linked a pull request Jul 19, 2023 that will close this issue
6 tasks
@Raidakarim Raidakarim mentioned this issue Jul 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical-path Issues that are critical path for deployment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants