From f4cd1c01f35e2cbe0978b733a56856f411e81743 Mon Sep 17 00:00:00 2001 From: Sebastian Stammler Date: Wed, 16 Mar 2022 10:55:25 +0100 Subject: [PATCH] channel: Use CloneAddresses in Params.Clone Signed-off-by: Sebastian Stammler --- channel/params.go | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/channel/params.go b/channel/params.go index 015c8847..d872b8ea 100644 --- a/channel/params.go +++ b/channel/params.go @@ -146,24 +146,10 @@ func NewParamsUnsafe(challengeDuration uint64, parts []wallet.Address, app App, // Clone returns a deep copy of Params. func (p *Params) Clone() *Params { - clonedParts := make([]wallet.Address, len(p.Parts)) - for i, part := range p.Parts { - marshalledAddr, err := part.MarshalBinary() - if err != nil { - log.WithError(err).Panic("Could not encode part") - } - - addr := wallet.NewAddress() - if err := addr.UnmarshalBinary(marshalledAddr); err != nil { - log.WithError(err).Panic("Could not clone params' addresses") - } - clonedParts[i] = addr - } - return &Params{ id: p.ID(), ChallengeDuration: p.ChallengeDuration, - Parts: clonedParts, + Parts: wallet.CloneAddresses(p.Parts), App: p.App, Nonce: new(big.Int).Set(p.Nonce), LedgerChannel: p.LedgerChannel,