Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support wasm use cases by removing time crate dependency #26

Open
pfernie opened this issue Jul 27, 2022 · 4 comments
Open

Support wasm use cases by removing time crate dependency #26

pfernie opened this issue Jul 27, 2022 · 4 comments

Comments

@pfernie
Copy link
Owner

pfernie commented Jul 27, 2022

As discussing in this reqwest issue, the transitive dependency on the time crate causes issues when targeting wasm. The upstream cookie-rs crate has a dependency here as well, so supporting this use case would involve an upstream change as well.
@pfernie pfernie mentioned this issue Jul 27, 2022
Open
@jhpratt
Copy link

jhpratt commented Jul 28, 2022

The time crate will support wasm via js-sys soon! There's an open PR.

@xy2i
Copy link

xy2i commented Jul 28, 2022

time-rs/time#491

@jkelleyrtp
Copy link

jkelleyrtp commented Sep 14, 2022 •
edited
Loading

The PR is up here #27 - would love to see this supported so I can move seanmonstar/reqwest#1449 forward

@pfernie
Copy link
Owner Author

pfernie commented Sep 17, 2022

#27 has been merged; I am leaving this issue open pending feedback that seanmonstar/reqwest#1449 can move forward with this change, at which point I can cut a 0.18.0 release including the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pfernie @jhpratt @jkelleyrtp @xy2i