Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins works just fine out of the box #102

Open
thiagomajesk opened this issue Nov 23, 2024 · 2 comments
Open

Plugins works just fine out of the box #102

thiagomajesk opened this issue Nov 23, 2024 · 2 comments

Comments

@thiagomajesk
Copy link

Hi! I found it curious that we have the following warning in the README:

Note: The stand-alone Tailwind client bundles first-class Tailwind packages within the precompiled executable. For third-party Tailwind plugin support (e.g. DaisyUI), the node package must be used

I might be reading this wrong, but the README seems to suggest that the node version of Tailwind is required for third-party plugin support, which doesn't seem to be the case (to be honest, I'm not sure if this was ever the case, since Phoenix used to ship with plugins to handle things like phx-no-feedback and phx-click-loading)

The PR that changed the README also doesn't go into detail on why this warning was added to begin with. Anyway, I've been using Daisy UI and other plugins for quite a while now, and it just works, so my question is, should we just remove this to avoid confusion?

@SteffenDE
Copy link
Contributor

Maybe something like this instead?

_Note_: The stand-alone Tailwind client bundles first-class Tailwind packages
within the precompiled executable. For third-party Tailwind plugin support (e.g. DaisyUI),
those must be installed using your Node.js package manager of choice in the directory where Tailwind is
executed from. For example: `npm install daisyui --save`.

@thiagomajesk
Copy link
Author

@SteffenDE At this point, I would just remove the note to avoid confusion.
I feel like teaching how to use a package manager is not really that helpful for a couple of reasons:

The Tailwind V3 docs already have a page that is dedicated to this: https://v3.tailwindcss.com/docs/plugins. Also, it looks like for V4 things have changed a lot (Vite vs Postcss; JS vs CSS), so it might be more useful to be agnostic and refer directly to the docs of the version and plugin in question. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants