fix GH-8533: dynamic libphp linking on Mac

[dunglas]

Closes #8533.

Tested as functional on macOS 15.2 (Sequoia), but this should work on older versions too.

[devnexen]

Note that, normally, only security fixes go in PHP 8.2 branch now.

[dunglas]

@devnexen rebased against 8.3 (I thought active support for 8.2 ended at the end of this year, sorry)

[devnexen]

No need to be sorry :) thanks for fixing this btw !

[bukka]

Is this specific only to libphp? Shouldn't this be applied on shared extensions as well?

[bukka]

What I mean is that if it would be possibly better handled in PHP_BUILD_SHARED instead.

[dunglas]

I thought about that but I fear that changing the extension name from foo.so to foo.dylib will break many existing setups.
That's why I made the changes minimal.

Also, the issue seems to happen only when linking libphp.

[bukka]

Ok it might be cleaner to add new type for PHP_SELECT_SAPI (e.g. shared-dynamic - probably needs a better name) and then handle it in PHP_BUILD_SHARED which sets the OVERALL_TARGET. It could check the platform and make the difference on darwin. That seems slightly cleaner to me.

[dunglas]

@bukka do you prefer something like that? I'm not sure it's cleaner but it's your call. OS detection must happen in embed/config.m4 because we must also change INSTALL_IT.

[bukka]

Ah ok, forgot about INSTALL_IT. It's probably still better than before so looks good to me. Let's wait for @petk for a bit to see if he has got any comments.

[petk]

Sorry for late reply. I'm not ignoring the PRs, just too busy elsewhere. 😃 If it works that's great. I'm not sure I'll have time to check this so soon. I'll see what I can do in the following days. Probably, there will be some minor adjustments needed for 8.4 and master branches as there is refactored library path.

[dunglas]

Any chance to get this merged @petk @bukka? This would help the Homebrew package for FrankenPHP.

[petk]

Builds and seems to work fine. Tested this a bit on macOS. Thanks @dunglas