Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Windows build failures are no longer treated as errors. #17818

Closed
nielsdos opened this issue Feb 15, 2025 · 2 comments · Fixed by #17820
Closed

CI Windows build failures are no longer treated as errors. #17818

nielsdos opened this issue Feb 15, 2025 · 2 comments · Fixed by #17820
Labels
Bug Category: Build System OS: Windows Status: Verified

Comments

@nielsdos
Copy link
Member

Description

Instead, it continues to the test step and there it fails: https://github.com/php/php-src/actions/runs/13345858377/job/37276209743

PHP Version

master

Operating System

No response
@nielsdos nielsdos linked a pull request Feb 15, 2025 that will close this issue
Fail build_task.bat if main nmake failed #17820
Merged
@cmb69
Copy link
Member

cmb69 commented Feb 15, 2025

Sorry, my mistake!

cmb69 added a commit that referenced this issue Feb 15, 2025
@cmb69
Fail build_task.bat if main nmake failed (GH-17820)
ed9c283 
Otherwise we may not notice Windows CI build failures.

Fixes GH-17818.
@nielsdos
Copy link
Member Author

Sorry, my mistake!

No worries, thx for fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Category: Build System OS: Windows Status: Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fail build_task.bat if main nmake failed cmb69/php-src
2 participants
@cmb69 @nielsdos