Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures on FreeBSD 14 #17864

Open
kevinmlowe opened this issue Feb 19, 2025 · 3 comments
Open

Test failures on FreeBSD 14 #17864

kevinmlowe opened this issue Feb 19, 2025 · 3 comments

Comments

@kevinmlowe
Copy link

Description

After running make it suggested I log this file.

Thanks for PHP!

php_test_results_20250219_1238.txt

Configure:

setenv PKG_CONFIG_PATH /usr/local/lib/pkgconfig

./configure
--with-apxs2=/usr/local/apache/bin/apxs
--without-pdo-sqlite --without-sqlite3 --without-iconv
--with-config-file-path=/usr/local/etc
--enable-bcmath --without-cdb
--enable-gd --without-iodbc
--without-gdbm --with-ndbm --without-db2 --without-dbm
--without-readline --with-openssl
--without-db3 --enable-dba
--with-curl
--with-jpeg --enable-calendar
--with-mhash --enable-mbstring=all
--with-zlib
--enable-exif --with-zip
--with-mysqli=mysqlnd

PHP Version

8.4

Operating System

FreeBSD 14

@cmb69
Copy link
Member

cmb69 commented Feb 19, 2025

Thanks for reporting!

Relevant info from the test results:

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
DBA NDBM handler test [ext/dba/tests/dba_ndbm.phpt]
Test setlocale() function : usage variations - Setting all available locales in the platform [ext/standard/tests/strings/setlocale_variation2.phpt]
=====================================================================


================================================================================
/usr/local/dev_build_sources/php-8.4.3/ext/dba/tests/dba_ndbm.phpt
================================================================================
Fatal error: Uncaught TypeError: set_up_db(): Argument #3 ($lock) must be of type LockFlag, false given, called in /usr/local/dev_build_sources/php-8.4.3/ext/dba/tests/dba_ndbm.php on line 6 and defined in /usr/local/dev_build_sources/php-8.4.3/ext/dba/tests/setup/setup_dba_tests.inc:72
Stack trace:
#0 /usr/local/dev_build_sources/php-8.4.3/ext/dba/tests/dba_ndbm.php(6): set_up_db('ndbm', 'dba_ndbm.db', false)
#1 {main}
  thrown in /usr/local/dev_build_sources/php-8.4.3/ext/dba/tests/setup/setup_dba_tests.inc on line 72
================================================================================

================================================================================
/usr/local/dev_build_sources/php-8.4.3/ext/standard/tests/strings/setlocale_variation2.phpt
================================================================================
*** Testing setlocale() : usage variations ***
-- Test setlocale() with all available locale in the system --
No of locales found on the machine = 198
No of setlocale() success = 193
Expected no of failures = 0
Test FAILED
Names of locale() for which setlocale() failed ...
array(5) {
  [0]=>
  string(15) "hr_HR.ISO8859-2"
  [1]=>
  string(15) "nl_BE.ISO8859-1"
  [2]=>
  string(16) "nl_BE.ISO8859-15"
  [3]=>
  string(15) "sr_RS.ISO8859-2"
  [4]=>
  string(10) "zh_TW.Big5"
}
Done
================================================================================

The dba_ndbm.phpt failure is actually expected; we're passing false to a parameter expecting a LockFlag. It seems to be a good idea to enable dba for our FreeBSD builds (I think ndbm is available there out of the box). cc @Girgias

I haven't look closely into the setlocale_variation2.phpt failure, but possibly there is something not quite right on your system, @kevinmlowe. On the other hand I wonder whether this tests makes much sense.

@cmb69 cmb69 changed the title 8.4 make test results on FreeBSD 14 Test failures on FreeBSD 14 Feb 19, 2025
@kevinmlowe
Copy link
Author

Hi no problem. I'd not be surprised if the problem was at my end, but I just thought I'd report it anyway!

@Girgias
Copy link
Member

Girgias commented Feb 20, 2025

Right, I think using LockFlag::DbLock probably makes the most sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants