Development branch - errors when trying to apply certain changes in Web interface (one in each of the three categories DNS, NTP, Miscellaneous)

[raspitoaster]

Versions

• Pi-hole: v5.18.4-587-g4c5285e4
• AdminLTE: v5.21-959-g7acf4647
• FTL: vDev-3ea253b

Platform

• OS and version: Debian Bookworm

• Platform: LXC

Expected behavior

When trying to save&apply settings modified in "All settings", the settings should be accepted.

Actual behavior / bug

When trying to save&apply settings modified in "All settings", some settings are not accepted:

deactivating checkbox "ntp.sync.active" always results in a popup
"Invalid configuration dnsmasq: syntax check OK."

setting "webserver.domain" to anything different from "pi.hole" always results in a popup
"Invalid configuration dnsmasq: syntax check OK."

activating checkbox "misc.etc_dnsmasq_d" always results in a popup
"Invalid configuration dnsmasq: syntax check OK."

Steps to reproduce

Do one of the below in SYSTEM - Settings - All settings,
then click "Save & Apply" and see the error.

• deactivating checkbox "ntp.sync.active"
• setting "webserver.domain" to anything different from "pi.hole"
• activating checkbox "misc.etc_dnsmasq_d"

[yubiuser]

Please generate a debug log and post the token here.

[DL6ER]

I did just try all of your suggested steps to reproduce and all of them succeeded as expected for me, e.g.:

It has to be something specific about your system - please generate and provide a debug token as asked for by @yubiuser using pihole -d and agree to upload in the end.

[DL6ER]

It'd also be very helpful if you could enable config debugging before you reproduce it next time:

sudo pihole-FTL --config debug.config true

The interesting lines will be in /var/log/pihole/FTL.log

[raspitoaster]

Thanks for your answers - debug mode has been set and the log has been uploaded: https://tricorder.pi-hole.net/yu3JyT75/

The issues are 100% reproducible, with Firefox (noscript, ublock) as well as with MS Edge (without any extension).
I can workaround the issues by changing the settings as needed in pihole.toml - and pihole loads them without any complains.
This way, even the webinterface reads them correctly and I can do "save and apply" them - e.g. with checkbox "ntp.sync.active" deactivated. Then activate, save&apply does work - but then unchecking, save&apply causes the popup "Invalid configuration dnsmasq: syntax check OK." again.

[rdwebdesign]

Can you please check if there are errors in the browser console (devtools) when the "Save and Apply" fails?

[raspitoaster]

I can access all pages and I can change any other settings but those 3 ones - e.g. the ntp.sync.active

[raspitoaster]

Just noticed:
if I manually set ntp.sync.active = false in pihole.toml , then I can apply the setting with the checkbox not checked in the WebGUI. If I try to save&apply now with the checkbox checked, then the error pops up.

Reverting the setting manually to the default in pihole.toml restores the problem that I cannot save&apply with the checkbox not checked.

[yubiuser]

I copied your pihole.toml into my v6 machine and only changed the password, but were able to change those 3 settings from the web interface without issues.

[DL6ER]

I first thought it didn't but your uploaded debug log has enough information to work on this. What happens here is that FTL receives SIGALRM during the test and incorrectly assumes this means the config test failed. I have no explanation where this signal is coming from but we'll make sure to provide a possible solution soon. It'd be great if you could assist in confirming if it works to fix what you are seeing.

[DL6ER]

@raspitoaster Please try

sudo pihole checkout ftl fix/dnsmasq_test_signal

and check if the issue is still there. If so, it'd be good to see new log output as some additional output might be there.

[raspitoaster]

@DL6ER Hello Dominik, I have applied your fix by executing "pihole checkout ftl fix/dnsmasq_test_signal" and can confirm that the issues are gone for all of the three settings - and also for additional ones that I found meanwhile.
Thanks a lot!

[DL6ER]

The fix has been merged into the development branch. Please run

sudo pihole checkout ftl development

to continue receiving future updates.

[DL6ER]

Closing as fixed