treeGetChildrenByIdAction has n+1 select issues

[cancan101]

Accessing treeGetChildrenByIdAction (/tree-get-children-by-id) exhibits n+1 select behavior:
Using data from Sentry:

The query handed to

admin-ui-classic-bundle/src/Controller/Admin/TagsController.php

Lines 155 to 182 in 7999ef4

	protected function convertTagToArray(Tag $tag, bool $showSelection, array $assignedTagIds, bool $loadChildren = false, bool $recursiveChildren = false): array
	{
	$tagArray = [
	'id' => $tag->getId(),
	'text' => $tag->getName(),
	'path' => $tag->getNamePath(),
	'expandable' => $tag->hasChildren(),
	'leaf' => !$tag->hasChildren(),
	'iconCls' => 'pimcore_icon_element_tags',
	'qtipCfg' => [
	'title' => 'ID: ' . $tag->getId(),
	],
	];
	if ($showSelection) {
	$tagArray['checked'] = isset($assignedTagIds[$tag->getId()]);
	}
	if ($loadChildren) {
	$children = $tag->getChildren();
	$loadChildren = $recursiveChildren;
	foreach ($children as $child) {
	$tagArray['children'][] = $this->convertTagToArray($child, $showSelection, $assignedTagIds, $loadChildren, $recursiveChildren);
	}
	}
	return $tagArray;
	}

looks to load lazily. something like may address the issue: https://www.doctrine-project.org/projects/doctrine-orm/en/3.2/reference/working-with-objects.html#by-eager-loading

[kingjia90]

Thank you for reporting!
I've opened 2 PRs that may help decreasing these queries, please see pimcore/pimcore#17390 and #629

Could you please apply the changes and re-run Sentry to see if there's an improvement? Thank you in advance

[kingjia90]

Marking this as done as the 2 PRs (pimcore/pimcore#17390 and #629) that might improve the behavior are merged

Let me know if you find anything else that we may improve or if it's not resolved and still occurs.