Set php 8.3 as min #810
Set php 8.3 as min #810
Conversation
|
| @@ -12,20 +12,20 @@ | |||
| "prefer-stable": true, | |||
| "minimum-stability": "dev", | |||
| "require": { | |||
| "php": "~8.1.0 || ~8.2.0 || ~8.3.0", | |||
| "php": "~8.3.0 || ~8.4.0", | |||
There was a problem hiding this comment.
according our meeting in the morning this line should be removed completely right?
There was a problem hiding this comment.
Please see: pimcore/generic-data-index-bundle#276 (comment)
It is better to always explicitly define the dependencies of a package instead of relying on the definition of another package. This is especially true for the PHP version, as you can no longer change it once a package version has been released.
There was a problem hiding this comment.
@alexz707 Yes, according to the meeting this should be removed. I figure out the that most of the test depends on this(see workflows). So we can refactor the test or keep this. We will talk tomorrow in the meeting :-)
No description provided.