Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken debug log: "readLoop exited EOF %!s(MISSING)" #112

Closed
enobufs opened this issue Feb 21, 2020 · 1 comment · Fixed by #113
Closed

Broken debug log: "readLoop exited EOF %!s(MISSING)" #112

enobufs opened this issue Feb 21, 2020 · 1 comment · Fixed by #113

Comments

@enobufs
Copy link
Member

enobufs commented Feb 21, 2020

Your environment.

  • Version: v1.7.4

A debug log is broken:

sctp DEBUG: 15:18:18.348686 association.go:434: [0xc00053a340] readLoop exited EOF %!s(MISSING)
@enobufs
Copy link
Member Author

enobufs commented Feb 24, 2020

The cause: rev 37f4ae9:

-    a.log.Debugf("[%s] readLoop exited", a.name)
+    a.log.Debugf("[%s] readLoop exited %s %s", a.name, closeErr)

Should be:

a.log.Debugf("[%s] readLoop exited %s", a.name, closeErr)

enobufs added a commit that referenced this issue Feb 24, 2020
@enobufs
Fix debug log format
6db64a5 
Resolves #112
@enobufs enobufs mentioned this issue Feb 24, 2020
Merged
enobufs added a commit that referenced this issue Feb 24, 2020
@enobufs
Fix debug log format
1c94953 
Resolves #112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix debug log format pion/sctp
1 participant
@enobufs