Add synchronization to payloadQueue map access #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map access are not concurrency safe, and the chunkmap of a payloadQueue is accessed by multiple goroutines. This commit adds a RWMutex to chunkmap accesses.
|
Alright, I'm not sure if you still want to add this considering #110 actually fixed the issue I was having. Sounds like we weren't triggering race conditions afterall. |
|
@cohosh The inflightQueue (which is a payloadQueue) is solely owned and accessed by Association, and it is protected by Association.lock. I have just gone over the code to double-check that and verified that's the case. Let me close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map access are not concurrency safe, and the chunkmap of a payloadQueue
is accessed by multiple goroutines. This commit adds a RWMutex to
chunkmap accesses.
Description
This PR is a possible solution to Issue #114. In any case, it fixes a race condition for maps that are accessed by multiple goroutines.
Reference issue
Fixes #114