Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Abort according to RFC 4960 #182

Closed
jeremija opened this issue Feb 20, 2021 · 1 comment · Fixed by #183
Closed

Implement Abort according to RFC 4960 #182

jeremija opened this issue Feb 20, 2021 · 1 comment · Fixed by #183

Comments

@jeremija
Copy link
Member

Currently the Close methods immediately closes the connection.

We should send an abort packet before closing the connection.

jeremija added a commit that referenced this issue Feb 20, 2021
According to RFC 4960. Also see my comment at #152.

Closes #182.

I don't think we currently do any tag verification for any packets, but
we can implement that later.
jeremija added a commit that referenced this issue Feb 20, 2021
According to RFC 4960. Also see my comment at #176.

Closes #182.

I don't think we currently do any tag verification for any packets, but
we can implement that later.
jeremija added a commit that referenced this issue Feb 20, 2021
According to RFC 4960. Also see my comment at #176.

Closes #182.

I don't think we currently do any tag verification for any packets, but
we can implement that later.
jeremija added a commit that referenced this issue Feb 20, 2021
According to RFC 4960. Also see my comment at #176.

Closes #182.

I don't think we currently do any tag verification for any packets, but
we can implement that later.
@enobufs
Copy link
Member

enobufs commented May 1, 2022

@jeremija My apologies for my long absence. I'd like to help resolving this. Let me review the PR.

jeremija added a commit that referenced this issue May 6, 2022
According to RFC 4960. Also see my comment at #176.

Closes #182.

I don't think we currently do any tag verification for any packets, but
we can implement that later.
jeremija added a commit that referenced this issue May 10, 2022
According to RFC 4960. Also see my comment at #176.

Closes #182.

I don't think we currently do any tag verification for any packets, but
we can implement that later.
jeremija added a commit that referenced this issue May 10, 2022
According to RFC 4960. Also see my comment at #176.

Closes #182.

I don't think we currently do any tag verification for any packets, but
we can implement that later.
jeremija added a commit that referenced this issue May 10, 2022
According to RFC 4960. Also see my comment at #176.

Closes #182.

I don't think we currently do any tag verification for any packets, but
we can implement that later.
enobufs pushed a commit that referenced this issue May 11, 2022
According to RFC 4960. Also see my comment at #176.

Closes #182.

I don't think we currently do any tag verification for any packets, but
we can implement that later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants