stream: Add "SetReadDeadline" #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enobufs
reviewed
Oct 16, 2022
Codecov ReportBase: 81.04% // Head: 80.92% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
==========================================
- Coverage 81.04% 80.92% -0.12%
==========================================
Files 48 48
Lines 3994 4032 +38
==========================================
+ Hits 3237 3263 +26
- Misses 618 628 +10
- Partials 139 141 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nerd2
force-pushed
the
sl_setreaddeadline
branch
from
3876589 to
396e5d5
Compare
enobufs
reviewed
Oct 16, 2022
nerd2
force-pushed
the
sl_setreaddeadline
branch
from
396e5d5 to
0883959
Compare
Add SetReadDeadline method to the Stream object to allow read timeout to be implemented
enobufs
force-pushed
the
sl_setreaddeadline
branch
from
0883959 to
659fc90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a read-deadline method similar to net.Conn/net.PacketConn to allow read timeouts to be implemented
Reference issue
Fixes #240