Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race in TestStreamClose introduced by the previous merge #242

Closed
enobufs opened this issue Oct 18, 2022 · 0 comments · Fixed by #243
Closed

Race in TestStreamClose introduced by the previous merge #242

enobufs opened this issue Oct 18, 2022 · 0 comments · Fixed by #243

Comments

@enobufs
Copy link
Member

enobufs commented Oct 18, 2022 •
edited
Loading

TestStreamClose in vnet_test.go causes a race during the test. The test was updated by the previous merge, race is occurring over an error object. Renaming the object in a goroutine would fix the race.
@enobufs enobufs changed the title Race in TestStreamClose introduced in the PR #238 Race in TestStreamClose introduced by the previous merge Oct 18, 2022
enobufs added a commit that referenced this issue Oct 18, 2022
@enobufs
Fix race in TestStreamClose introduced by #238
eb183f3 
Fixes #242
@enobufs enobufs mentioned this issue Oct 18, 2022
Merged
pionbot pushed a commit that referenced this issue Oct 18, 2022
@enobufs
Fix race in TestStreamClose introduced by #238
38d26c7 
Fixes #242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix race in TestStreamClose introduced by #238 pion/sctp
1 participant
@enobufs