From 40fef09ada765427642e631b5c77030f9f54d071 Mon Sep 17 00:00:00 2001 From: Piotr Roslaniec Date: Wed, 7 Dec 2022 13:23:25 +0100 Subject: [PATCH] chore: move todo to issue #130 --- src/characters/alice.ts | 1 - src/web3.ts | 1 - 2 files changed, 2 deletions(-) diff --git a/src/characters/alice.ts b/src/characters/alice.ts index cdec49e68..2aea2db4e 100644 --- a/src/characters/alice.ts +++ b/src/characters/alice.ts @@ -44,7 +44,6 @@ export class Alice { public static fromSecretKey( config: Configuration, secretKey: SecretKey, - // TODO: Avoid using ethers types in interfaces directly web3Provider: ethers.providers.Web3Provider ): Alice { const web3 = Web3Provider.fromEthersWeb3Provider(web3Provider); diff --git a/src/web3.ts b/src/web3.ts index 5f8d9fb02..df2391ee1 100644 --- a/src/web3.ts +++ b/src/web3.ts @@ -3,7 +3,6 @@ import { ethers } from 'ethers'; import { ChecksumAddress } from './types'; import { fromHexString } from './utils'; -// TODO: Remove this abstraction and use ethers directly? export class Web3Provider { private constructor( private readonly web3Provider: ethers.providers.Web3Provider