Skip to content

Commit

Permalink
fix: clang++ 19 compilation error
Browse files Browse the repository at this point in the history
It is not quite clear why this code does not compile only now and using
a new version of clang. Most probably, this is dead code (since using
an inaccessible/unknown `chain_` here should never compile) and clang 19
is just now a bit more aggressive in checking more things at compile
time or in a constexpr context.

If true, there is probably place to clean code further, like maybe
completely removing the `Chainer<void, Dummy>` class specialization.

But for now and without deeper knowledge or analysis this change should
not result in any behavior change and make it compile again.

Fix #1243
  • Loading branch information
sjoubert committed Sep 18, 2024
1 parent fd5280a commit 6eb5d4d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions include/pistache/async.h
Original file line number Diff line number Diff line change
Expand Up @@ -708,8 +708,7 @@ namespace Pistache::Async

void operator()()
{
auto core = this->chain_;
core->state = State::Fulfilled;
chainCore->state = State::Fulfilled;

for (const auto& req : chainCore->requests)
{
Expand Down
2 changes: 1 addition & 1 deletion version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.4.5.20240910
0.4.5.20240918

0 comments on commit 6eb5d4d

Please sign in to comment.