From 6eb5d4dc49f039b404eebc44242a267fe72ddecd Mon Sep 17 00:00:00 2001 From: Sylvain Joubert Date: Tue, 17 Sep 2024 14:56:19 +0200 Subject: [PATCH] fix: clang++ 19 compilation error It is not quite clear why this code does not compile only now and using a new version of clang. Most probably, this is dead code (since using an inaccessible/unknown `chain_` here should never compile) and clang 19 is just now a bit more aggressive in checking more things at compile time or in a constexpr context. If true, there is probably place to clean code further, like maybe completely removing the `Chainer` class specialization. But for now and without deeper knowledge or analysis this change should not result in any behavior change and make it compile again. Fix #1243 --- include/pistache/async.h | 3 +-- version.txt | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/pistache/async.h b/include/pistache/async.h index 392375515..c6e984287 100644 --- a/include/pistache/async.h +++ b/include/pistache/async.h @@ -708,8 +708,7 @@ namespace Pistache::Async void operator()() { - auto core = this->chain_; - core->state = State::Fulfilled; + chainCore->state = State::Fulfilled; for (const auto& req : chainCore->requests) { diff --git a/version.txt b/version.txt index d85c9a49b..2c4115479 100644 --- a/version.txt +++ b/version.txt @@ -1 +1 @@ -0.4.5.20240910 +0.4.5.20240918