From 9b29c588c28f6bb792486e4d5425d0784304846c Mon Sep 17 00:00:00 2001 From: Dom Del Nano Date: Mon, 2 Dec 2024 17:45:37 +0000 Subject: [PATCH] Fix linting Signed-off-by: Dom Del Nano --- src/stirling/utils/linux_headers.cc | 3 ++- src/vizier/services/agent/kelvin/kelvin_main.cc | 8 ++++---- src/vizier/services/agent/pem/pem_main.cc | 3 ++- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/stirling/utils/linux_headers.cc b/src/stirling/utils/linux_headers.cc index e86a996dded..b147e28500d 100644 --- a/src/stirling/utils/linux_headers.cc +++ b/src/stirling/utils/linux_headers.cc @@ -214,7 +214,8 @@ Status LinkHostLinuxHeadersKernel(const std::filesystem::path& lib_modules_dir) const auto host_path = system::Config::GetInstance().ToHostPath(lib_modules_dir); LOG(INFO) << absl::Substitute("Looking for host Linux headers at $0.", host_path.string()); - PX_ASSIGN_OR_RETURN(const auto resolved_host_path, system::ResolvePossibleSymlinkToHostPath(host_path)); + PX_ASSIGN_OR_RETURN(const auto resolved_host_path, + system::ResolvePossibleSymlinkToHostPath(host_path)); PX_RETURN_IF_ERROR(fs::CreateSymlinkIfNotExists(resolved_host_path, lib_modules_dir)); LOG(INFO) << absl::Substitute("Linked host headers at $0 to symlink in pem namespace at $1.", resolved_host_path.string(), lib_modules_dir.string()); diff --git a/src/vizier/services/agent/kelvin/kelvin_main.cc b/src/vizier/services/agent/kelvin/kelvin_main.cc index 3f1136ec446..ed5b0eee2b2 100644 --- a/src/vizier/services/agent/kelvin/kelvin_main.cc +++ b/src/vizier/services/agent/kelvin/kelvin_main.cc @@ -91,11 +91,11 @@ int main(int argc, char** argv) { LOG(INFO) << absl::Substitute("Pixie Kelvin. Version: $0, id: $1, kernel: $2", px::VersionInfo::VersionString(), agent_id.str(), kernel_version.ToString()); - auto manager = - KelvinManager::Create(agent_id, FLAGS_pod_name, FLAGS_host_ip, addr, FLAGS_rpc_port, - FLAGS_nats_url, mds_addr, kernel_version, /* kernel_headers_installed */ false) + auto manager = KelvinManager::Create(agent_id, FLAGS_pod_name, FLAGS_host_ip, addr, + FLAGS_rpc_port, FLAGS_nats_url, mds_addr, kernel_version, + /* kernel_headers_installed */ false) - TerminationHandler::set_manager(manager.get()); + TerminationHandler::set_manager(manager.get()); PX_CHECK_OK(manager->Run()); PX_CHECK_OK(manager->Stop(std::chrono::seconds{1})); diff --git a/src/vizier/services/agent/pem/pem_main.cc b/src/vizier/services/agent/pem/pem_main.cc index ceda73dfa9c..719c18b9777 100644 --- a/src/vizier/services/agent/pem/pem_main.cc +++ b/src/vizier/services/agent/pem/pem_main.cc @@ -75,7 +75,8 @@ int main(int argc, char** argv) { auto kernel_headers_installed = false; auto uname = px::system::GetUname(); if (uname.ok()) { - const auto host_path = px::system::Config::GetInstance().ToHostPath(absl::Substitute("$0/$1/$2", kLinuxHeadersPath, uname.ConsumeValueOrDie(), "build")); + const auto host_path = px::system::Config::GetInstance().ToHostPath( + absl::Substitute("$0/$1/$2", kLinuxHeadersPath, uname.ConsumeValueOrDie(), "build")); const auto resolved_host_path = px::system::ResolvePossibleSymlinkToHostPath(host_path); kernel_headers_installed = resolved_host_path.ok();