Fix getSupportedLocales calls where submisison locales are meant to be

[bozana]

Now that we separated submission and metadata locales from context's UI and form locales (s. #9425), the places in the code where getSupportedLocales or getSupportedFormLocales are used need to be double checked and fixed if actually the submission and metadata locales are meant to be there.
Often this is used to get controlled vocabulary data like getKeywords, getSubjects, getDisciplines, getAgencies.

PRs:

• pkp/pkp-lib#10726 consider all existing submission metadata langauges #10728
• pkp/pkp-lib#10726 consider all existing submission metadata langauges ojs#4564
• pkp/pkp-lib#10726 consider all existing submission metadata langauges omp#1789
• pkp/pkp-lib#10726 consider all existing submission metadata langauges ops#829
• pkp/pkp-lib#10726 consider all existing submission metadata langauges citationStyleLanguage#139
• pkp/pkp-lib#10726 consider all existing submission metadata langauges jatsTemplate#67

[bozana]

Hi @touhidurabir, could you please review the PRs above? (They are connected with controlled vocabularies that you are currently working on...)

[touhidurabir]

@bozana i suggest these to get merge a bit later after the merge of #10292 . Pretty all these DAO has been removed so these changes are need to be adjusted accordingly for new implementation .

[touhidurabir]

Hi @bozana the PRs from #10292 are merged . the changes for most of the above PRs are mostly have some conflict as those lines have updated . If I am not mistaken , the changes are like below

Repo::controlledVocab()->getBySymbolic(
    ControlledVocab::CONTROLLED_VOCAB_SUBMISSION_KEYWORD,
    Application::ASSOC_TYPE_PUBLICATION,
    $publication->getId(),
    $journal->getSupportedSubmissionLocales()
);

and considering your PRs , I think you mostly need to remove the param $journal->getSupportedSubmissionLocales() .

[bozana]

Hi @touhidurabir, I rebased. Could you please review the PRs?
The pkp-lib PR contains one more change -- I think the allowed locales for a submission were wrong.
Thanks a lot!

[touhidurabir]

Hi @bozana all seems ok but tests are failing for OMP/OPS , seems require a rebase with ui-library . Once all tests pass, it should be good to merge .