Fix parameter when invoking pktgen_main_receive #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aniurm <[email protected]>
|
Does this change fix the problem you are seeing? It looks like a good fix in any case. |
|
"Does this change fix the problem you are seeing" No this fix can't solve #153 (comment) This fix is about the configuration of burst size. It can solve part of my problem. #153 (comment) the main issue is the weird stuff when I set burst size to 1. |
KeithWiles
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should pass
rx_bursttopktgen_main_receive, since this function handles packet reception.Otherwise, the command
set <portlist> txburst <value>might unintentionally affect the receive behavior in Pktgen.