From 4a470e6511cb72c91fc1044321bd45f64d81c512 Mon Sep 17 00:00:00 2001 From: Kouhei Yanagita Date: Sat, 5 Oct 2024 20:50:29 +0900 Subject: [PATCH] Call ignore_model_if before RbsRails::ActiveRecord.generatable? RbsRails::ActiveRecord.generatable? may raise an exception. For example, this occurred when using ActiveType::Object. https://github.com/makandra/active_type If we call ignore_model_if before generatable?, we can handle such cases by adding models that cause errors to ignore_model_if. --- lib/rbs_rails/rake_task.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rbs_rails/rake_task.rb b/lib/rbs_rails/rake_task.rb index 3187eff..dd307c5 100644 --- a/lib/rbs_rails/rake_task.rb +++ b/lib/rbs_rails/rake_task.rb @@ -36,8 +36,8 @@ def def_generate_rbs_for_models dep_builder = DependencyBuilder.new ::ActiveRecord::Base.descendants.each do |klass| - next unless RbsRails::ActiveRecord.generatable?(klass) next if ignore_model_if&.call(klass) + next unless RbsRails::ActiveRecord.generatable?(klass) path = signature_root_dir / "app/models/#{klass.name.underscore}.rbs" path.dirname.mkpath