Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.8 compatibility #2

Open
pokulo opened this issue Aug 12, 2024 · 1 comment
Open

python 3.8 compatibility #2

pokulo opened this issue Aug 12, 2024 · 1 comment
Assignees

Comments

@pokulo
Copy link
Owner

pokulo commented Aug 12, 2024

Description

This package is not compatible with Python 3.8 since commit e691d5a, see e.g.:

Traceback (most recent call last):
  File "/home/…/.local/bin/http_converter", line 5, in <module>
    from http_converter import main
  File "/home/…/.local/pipx/venvs/errno_converter/lib/python3.8/site-packages/http_converter.py", line 4, in <module>
    from lib.converter import Converter
  File "/home/…/.local/pipx/venvs/errno_converter/lib/python3.8/site-packages/lib/converter.py", line 5, in <module>
    class Converter(object, metaclass=abc.ABCMeta):
  File "/home/…/.local/pipx/venvs/errno_converter/lib/python3.8/site-packages/lib/converter.py", line 26, in Converter
    def get_candidates() -> list[str]:
TypeError: 'type' object is not subscriptable

Affected Version

Commit e691d5a changed app version in pyproject.toml to 0.1.5. But git version tags are missing!

Proposed Solution

This could be solved by using backported typing imports like this one:

from __future__ import annotations
@pokulo pokulo self-assigned this Aug 12, 2024
@pokulo
Copy link
Owner Author

pokulo commented Jan 11, 2025

python 3.8 ist EOL. so the pyproject.toml might just raise compatibility flag to python 3.9 and later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant