Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu missing #370

Open
khatchad opened this issue Oct 1, 2024 · 0 comments
Open

Menu missing #370

khatchad opened this issue Oct 1, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed ui UI related bug.

Comments

@khatchad
Copy link
Member

khatchad commented Oct 1, 2024

The UI plug-in menu is missing. The plug-in can still be run using a command; that works fine.

Regression

I't specified here:

<extension point="org.eclipse.ui.menus">
<menuContribution locationURI="menu:org.python.pydev.refactoring.refactoringMenu?after=additions">
<!-- [rk] Doesn't seem to be working -->
<command commandId="edu.cuny.hunter.hybridize.function.command" id="edu.cuny.hunter.hybridize.function.menus.command" label="%HybridizeFunctionLabel" mnemonic="%command.mnemonic">
<visibleWhen>
<reference definitionId="edu.cuny.hunter.hybridize.ui.definitions.actionSet" />
</visibleWhen>
</command>
</menuContribution>
<menuContribution locationURI="popup:org.python.pydev.refactoring.refactoringMenu?after=additions">
<command commandId="edu.cuny.hunter.hybridize.function.command" label="%HybridizeFunctionLabel" style="push">
<visibleWhen>
<reference definitionId="edu.cuny.hunter.hybridize.ui.definitions.actionSet" />
</visibleWhen>
</command>
</menuContribution>
</extension>

The eval plug-in one works fine:

<extension
point="org.eclipse.ui.menus">
<menuContribution
locationURI="menu:org.eclipse.ui.main.menu?after=additions">
<menu
id="edu.cuny.hunter.hybridize.eval.menus.evaluate"
label="Evaluate Hybridize Functions"
mnemonic="E">
<command
commandId="edu.cuny.hunter.hybridize.eval.commands.evaluate"
icon="icons/sample.png"
label="Evaluate Hybridize Functions refactoring"
mnemonic="E"
style="push"
tooltip="Evaluate Hybridize Functions refactoring">
</command>
</menu>
</menuContribution>
<menuContribution
locationURI="toolbar:org.eclipse.ui.main.toolbar?after=additions">
<toolbar
id="edu.cuny.hunter.hybridize.eval.toolbars.evaluate"
label="Evaluate Hybridize Functions Refactoring">
<command
id="edu.cuny.hunter.hybridize.eval.toolbars.evaluate"
commandId="edu.cuny.hunter.hybridize.eval.commands.evaluate"
icon="icons/sample.png"
tooltip="Evaluate Hybridize Functions refactoring">
</command>
</toolbar>
</menuContribution>
</extension>

But, that one uses the Eclipse menus, while the UI plug-in uses the PyDev ones (unsure if that has something to do with it or not).

@khatchad khatchad added bug Something isn't working help wanted Extra attention is needed ui UI related bug. labels Oct 1, 2024
khatchad added a commit that referenced this issue Oct 1, 2024
Due to #370.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed ui UI related bug.
Projects
None yet
Development

No branches or pull requests

1 participant