Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter bug fixes by SHA #161

Open
khatchad opened this issue Dec 14, 2021 · 9 comments
Open

Filter bug fixes by SHA #161

khatchad opened this issue Dec 14, 2021 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@khatchad
Copy link
Member

I have a SHA. I want to see the bug fix page for that SHA. How can I do it?

@khatchad khatchad added the enhancement New feature or request label Dec 14, 2021
@y3pio y3pio self-assigned this Jan 11, 2025
@y3pio
Copy link
Collaborator

y3pio commented Jan 11, 2025

Maybe a search bar on top, something like what the commits table is doing with rounds? We can follow a similar pattern and expose a query param to filter by SHA. -- Let me know if this sounds good @khatchad !

image

@khatchad
Copy link
Member Author

Rounds is a drop down box I think.

@y3pio
Copy link
Collaborator

y3pio commented Jan 15, 2025

Rounds is a drop down box I think.

Yup, I just meant adding something in that space above the header, like an input field of some sort, where you can enter a SHA to filter by. -- Will proceed with adding this!

@khatchad
Copy link
Member Author

It can be a drop down box, because you may not know what the SHA1 is that you want to filter.

@khatchad
Copy link
Member Author

The drop down box would be populated with the existing SHA1s, like (I think) the rounds is.

@khatchad
Copy link
Member Author

I have a SHA. I want to see the bug fix page for that SHA. How can I do it?

Ah, but maybe I was looking for something like a search box according to this description.

@khatchad
Copy link
Member Author

I guess a happy medium would be to have a searchable drop down box like the one in Google Sheets.

Maybe something like this?

@y3pio
Copy link
Collaborator

y3pio commented Jan 16, 2025

It can be a drop down box, because you may not know what the SHA1 is that you want to filter.

Hmm should it just be an input then in that case? Just trying to understand the use case for a dropdown (i.e when would a user open the drop down and scroll through the list of SHAs?).

I guess a happy medium would be to have a searchable drop down box like the one in Google Sheets.

Similarly for a searchable dropdown -- would there ever be a case where you would partially know the SHA you're looking for and the dropdown would show you a list of SHAs that matches the pattern, in which case the dropdown would be a useful UX to allow the user to narrow down the SHA/item they're looking for.

@y3pio
Copy link
Collaborator

y3pio commented Jan 17, 2025

Raised a PR to add filtering for the bug_fixes table, let me know if this looks ok! Looking into the commits table now, will need to look into it a bit further as it already has an existing "Round" filter to ensure filtering the SHA works along side it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants