-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix page shows empty categorization table #162
Comments
Hi @khatchad , could you clarify what the expected behavior should be? I'm seeing this page on my local dev using the migrated/fixture data for issue # 109(?) http://localhost:8000/bug_fixes/109/: |
No categorizations for a bug fix should not show the page at all. At least that was my original idea, but it seems that there is other information there. |
Got cha. If you feel the existing info that's being displayed is useful, I can leave it as is and close out this issue. Otherwise, will put in a fix to not allow users to navigate to this bug fix page if there are no categorizations (maybe display the anchor link from the table). |
I can't remember exactly, but I must have had in my mind that the page is not useful if there are no categorizations. An alternative would be to keep the info but instead of displaying an empty table display a message or something that says no categorizations. Either way, I don't think that the issue should close without some action. |
Having an table without rows isn't desirable. |
Raised a PR to conditionally render the categorization table section on the bug fix template. Let me know if this looks ok! |
No categorizations for a bug fix should not show the page at all:
https://fathomless-inlet-57767.herokuapp.com/bug_fixes/109/
The text was updated successfully, but these errors were encountered: