Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix page shows empty categorization table #162

Open
khatchad opened this issue Dec 14, 2021 · 6 comments
Open

Bug fix page shows empty categorization table #162

khatchad opened this issue Dec 14, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@khatchad
Copy link
Member

No categorizations for a bug fix should not show the page at all:

https://fathomless-inlet-57767.herokuapp.com/bug_fixes/109/

@khatchad khatchad added bug Something isn't working enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working labels Dec 14, 2021
@y3pio
Copy link
Collaborator

y3pio commented Jan 11, 2025

Hi @khatchad , could you clarify what the expected behavior should be? I'm seeing this page on my local dev using the migrated/fixture data for issue # 109(?) http://localhost:8000/bug_fixes/109/:

image

@y3pio y3pio self-assigned this Jan 11, 2025
@khatchad
Copy link
Member Author

No categorizations for a bug fix should not show the page at all. At least that was my original idea, but it seems that there is other information there.

@y3pio
Copy link
Collaborator

y3pio commented Jan 15, 2025

Got cha. If you feel the existing info that's being displayed is useful, I can leave it as is and close out this issue. Otherwise, will put in a fix to not allow users to navigate to this bug fix page if there are no categorizations (maybe display the anchor link from the table).

@khatchad
Copy link
Member Author

I can't remember exactly, but I must have had in my mind that the page is not useful if there are no categorizations. An alternative would be to keep the info but instead of displaying an empty table display a message or something that says no categorizations. Either way, I don't think that the issue should close without some action.

@khatchad
Copy link
Member Author

Having an table without rows isn't desirable.

@y3pio
Copy link
Collaborator

y3pio commented Jan 16, 2025

Raised a PR to conditionally render the categorization table section on the bug fix template. Let me know if this looks ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants