Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to create, update, and delete bug fixes #71

Open
khatchad opened this issue Mar 20, 2021 · 13 comments
Open

Add the ability to create, update, and delete bug fixes #71

khatchad opened this issue Mar 20, 2021 · 13 comments

Comments

@khatchad
Copy link
Member

khatchad commented Mar 20, 2021

Note that this should be done only by users having a particular role per #17.

  • Creating should be done by reconcilers and above.
  • Update can be done by reconcilers and above.
  • Delete can only be done by admins.
  • Categorizers can only view bug fixes.
@mZneit
Copy link
Contributor

mZneit commented Mar 30, 2021

This is the commit. 28a880a

The form creates new bugfixes, updates, and deletes them. I added a search by round filter but not activated yet. I'm not sure if it's needed.

@khatchad
Copy link
Member Author

I think the round is useful but it should be a dropdown prepopulated with the rounds that relate to the bug fix table. Thanks, Manal!

@mZneit
Copy link
Contributor

mZneit commented Mar 30, 2021

ok will do this.

@khatchad
Copy link
Member Author

I think this needs more discussion, @mZneit. Particularly, bug fixes should be created from categorizations. Please set up a meeting next week to discuss the workflow further.

@khatchad
Copy link
Member Author

The update makes sense though.

@khatchad
Copy link
Member Author

But you can see that the creation is not quite right because the SHA is blank. This will need to be more like how categorizations are created from commits, e.g., https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations/add?commit=00a33f7e060caa6616c15003bdac95b7926b76ae

@khatchad
Copy link
Member Author

khatchad commented Mar 30, 2021

Also, the routes are not quite right. See the article I posted last week.

@khatchad
Copy link
Member Author

Actually, adding and editing bug fixes should only be done by reconcilers. Thus, this is really blocked on #17. I would move this out of the main branch and put it on a feature branch.

@mZneit
Copy link
Contributor

mZneit commented Mar 30, 2021

I think this needs more discussion, @mZneit. Particularly, bug fixes should be created from categorizations. Please set up a meeting next week to discuss the workflow further.

Ok. I will.

@mZneit
Copy link
Contributor

mZneit commented Mar 30, 2021

But you can see that the creation is not quite right because the SHA is blank. This will need to be more like how categorizations are created from commits, e.g., https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations/add?commit=00a33f7e060caa6616c15003bdac95b7926b76ae

Yes, but the form doesn't submit if it's blank, it's a required field. But I agree that it should come from commits.

@khatchad
Copy link
Member Author

Thanks, @mZneit. I think we will need #17 before we can really have this one.

@mZneit
Copy link
Contributor

mZneit commented Mar 31, 2021

I will not work on it at this moment, but do we need to move it to another branch?

@khatchad
Copy link
Member Author

I believe so, because we don't want categorizers accidently modifying existing bug fixes. The idea of #17 is that only reconcilers will be able to do that. Since there is only one "role" now, everyone is categorizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants