Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting any environment duplicates variables pane entry #5887

Open
jonvanausdeln opened this issue Jan 6, 2025 · 1 comment
Open

Restarting any environment duplicates variables pane entry #5887

jonvanausdeln opened this issue Jan 6, 2025 · 1 comment
Labels
area: notebooks Issues related to Notebooks category. area: variables Issues related to Variables category. bug Something isn't working needs automated test Issue is candidate for automated test regression

Comments

@jonvanausdeln
Copy link
Contributor

jonvanausdeln commented Jan 6, 2025

System details:

Positron and OS details:

Positron Version: 2025.01.0 (system setup) build 152
Code - OSS Version: 1.95.0
Commit: 66aa3fb
Date: 2025-01-06T02:53:20.465Z
Electron: 32.2.1
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.26100

Interpreter details:

Python 3.10.10 (version doesn't matter)

Describe the issue:

Restarting notebook any interpreter environment creates a duplicate entry in the variable pane drop down

Steps to reproduce the issue:

  1. Start a new Python or R notebook... or just a console.
  2. Note the entry in the variable pane
  3. Click "Restart" on the notebook

This creates a duplicate entry in the variables pane

Expected or desired behavior:

Only 1 entry in variables pane for the notebook env.

Were there any error messages in the UI, Output panel, or Developer Tools console?

@jonvanausdeln jonvanausdeln added area: notebooks Issues related to Notebooks category. needs automated test Issue is candidate for automated test labels Jan 6, 2025
@jonvanausdeln
Copy link
Contributor Author

QA Note: We should add an automated tests for this type of behavior as we had something similar in #2658

@jonvanausdeln jonvanausdeln changed the title Restarting Notebook environment duplicates variables pane entry Restarting any environment duplicates variables pane entry Jan 6, 2025
@juliasilge juliasilge added this to the 2025.02.0 Pre-Release milestone Jan 6, 2025
@juliasilge juliasilge added regression area: variables Issues related to Variables category. bug Something isn't working labels Jan 6, 2025
jonvanausdeln added a commit that referenced this issue Jan 17, 2025
### Intent 

To help test #5887 these new tests ensure that after an interpreter env is restarted, it doens't create a duplicate entry in variables pane.

### Approach

* Restarts interpreter and checks that only 1 still exists
* R & Python.. I thought adding a notebook version would be unnecessary, but can if needed.

### QA Notes

Tests are skipped now due to the issue. But you can check the tests by removing the skip and it will fail with

```
    Error: expect(received).toBe(expected) // Object.is equality

    Expected: 1
    Received: 2

```
All other variable tests should still pass 
@:variables

<!--
  Add additional information for QA on how to validate the change,
  paying special attention to the level of risk, adjacent areas that
  could be affected by the change, and any important contextual
  information not present in the linked issues.
-->
@softwarenerd softwarenerd self-assigned this Jan 21, 2025
@softwarenerd softwarenerd removed their assignment Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: notebooks Issues related to Notebooks category. area: variables Issues related to Variables category. bug Something isn't working needs automated test Issue is candidate for automated test regression
Projects
None yet
Development

No branches or pull requests

3 participants