Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py-shiny-validate to shinylive #12

Open
thohan88 opened this issue Jan 9, 2025 · 2 comments
Open

Add py-shiny-validate to shinylive #12

thohan88 opened this issue Jan 9, 2025 · 2 comments

Comments

@thohan88
Copy link

thohan88 commented Jan 9, 2025

This may be more appropriate to file in py-shinylive.

It would be useful if shinylive included this package by default, so that you did not need to add it in requirements.txt.

@gadenbuie
Copy link
Contributor

Thanks for the suggestion! Generally speaking, the packages we include in shinylive are included to avoid compilation issues with pyodide or to ensure compatibility with the pyodide used by shinylive. There are a number of trade-offs that come with including a package in the shinylive assets (size of the bundled assets and ease of updating are two key issues), so on the balance we try not to include pure-Python packages in the bundle (beyond Shiny and it's direct dependencies).

@thohan88
Copy link
Author

thohan88 commented Jan 9, 2025

Fair trade-off! I saw packages such as faicons included and suspected that these were quite similar, and that it may have just been forgotten. Feel free to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants